(#158) Split out list command to its own command class #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
list-local-only
branch
from
34f871e to
6e15f78
Compare
AdmiringWorm
force-pushed
the
list-local-only
branch
from
6e15f78 to
d2ec2ec
Compare
AdmiringWorm
force-pushed
the
list-local-only
branch
from
d2ec2ec to
e489123
Compare
corbob
requested changes
Mar 17, 2023
vexx32
reviewed
Mar 17, 2023
src/chocolatey/infrastructure.app/commands/ChocolateyListCommand.cs
Outdated
Show resolved
Hide resolved
(chocolatey#158) Remove list alias for remote searches This commit removes the list alias for remote searches and renames the command class to be ChocolateySearchCommand to reflect it is for remote searches. As a side effect, the Info command now inherits from the search command which should be fine in most cases.
This commit moves everything related to listing local packages to its own new class that will only be responsible for listing local packages. This also changes the behavior of the search and find commands to only be able to search on remote feeds.
This commit updates the tab completion by removing the now unsupported arguments on the list command and remove local only arguments from the search command. Additionally, as it was found to be missing, the find command was also added to the tab completion.
Remove extraneous comments Space out Tags Add Tag parameter where missing.
Be explicit with unsupported arguments so we don't accidentally warn on packages with those names.
corbob
approved these changes
Mar 17, 2023
|
Thank you for getting this done @AdmiringWorm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull requests splits out the list command to be its own command in the source codes, which can only handle local packages and not remote sources.
In this move, all arguments that had been deprecated for the list command have been completely removed from the list command, and a few remote only arguments will be warning about that they are unsupported (this won't do anything at all).
The tab completion file has also been updated with this new logic, with an adition that remote searches have had their local arguments removed from the tab completion.
Motivation and Context
To make list searching only local packages, while using search and find will be for remote sources.
Testing
choco listchoco searchagainst a feed not containing 1 or more of the installed pakcageschoco list --local-onlychoco search --local-only --verbose--local-onlychoco info chocolatey --local-onlychoco info upgradepackage(against internal repository source)ListCommand,SearchCommandandInfoCommandOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
choco listto be local only #158